add a JSON encoder to encode Argument#4
Merged
Conversation
njzjz
commented
Jul 26, 2021
Comment on lines
+659
to
+678
| if isinstance(obj, Argument): | ||
| return { | ||
| "name": obj.name, | ||
| "type": obj.dtype, | ||
| "alias": obj.alias, | ||
| "doc": obj.doc, | ||
| "sub_filed": obj.sub_fields, | ||
| "fold_subdoc": obj.fold_subdoc, | ||
| "repeat": obj.repeat, | ||
| "sub_fields": obj.sub_fields, | ||
| "sub_variants": obj.sub_variants, | ||
| } | ||
| elif isinstance(obj, Variant): | ||
| return { | ||
| "flag_name": obj.flag_name, | ||
| "optional": obj.optional, | ||
| "default_tag": obj.default_tag, | ||
| "choice_dict": obj.choice_dict, | ||
| "doc": obj.doc, | ||
| } |
Member
Author
There was a problem hiding this comment.
@y1xiaoc Here please check if any information is missing.
y1xiaoc
reviewed
Jul 26, 2021
Member
Author
|
@y1xiaoc, ready to review. |
y1xiaoc
approved these changes
Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3.
Here is the DeePMD-kit JSON file:
deepmd.txt
@y1xiaoc Please check if any information is missing.